Posts

Showing posts from April, 2018

#Brave-laptop dev: interesting issue part 2

Image
This is a continuation from my previous blog, I've done further investigation and discovered that the favicon was being invalidated (redownloaded) every frame. and upon further investigation I found that the response header contained the following I did some research and found that modifying this is no easy task and that this setting forces the Favicon to be redownloaded  every time it's updated. Which in this case was every frame since it was being redrawn along with the gradient affect that follows the mouse. My attempts at figuring out how to modify the layer that the favicon is being drawn in is falling flat so far. I got some feedback from some of the brave developers on how to proceed after I declared these findings, that the issue can be resolved by manually saving the image as a URI and adding it to the CSS, but I haven't been able figure out how to convert a image to an URI.

#Brave-laptop dev: interesting issue and how I attempted to fix it

Image
So I came across this issue that causes the icon to flicker when the mouse moves back and forth on a tab, but only for certain sites, Before:  the fix I discovered is removing one line of code that set the next frame to null for the animation to setup for the next frame, but from my guess that was causing issues with the icon frame being null every split second. After: I fixed this in record time, only about 45 min... if only all bugs were that easy to fix.    How did I find the code required? well glad you asked, First off I used the inspector of the dev tools (opened by pressing shift-F8 and selecting the ) and selected the favicon and scrolled up so I could see the class information for the tabs. noticing the --tab-mouse-x changes I decided to look that up in the project using "Atom" as my editor pressing ctrl-shift-f allows me to search the whole project for a keyword.   lucky me it only found 1 match, this is unusual, pressing on the match it bo