#Brave-laptop dev: Being brave with my first issue (WIP)

Brave Issue

I decided to be brave with my first brave issue, https://github.com/brave/browser-laptop/issues/12458
in the comments they stated that it's not a trivial fix.

alt-f on firefox
The Issue pertains to pressing alt-"key" to open one of the alt menu options, it exists in Firefox like so.



















I've tried various things to get this to work, like adding a new windowAction, but discovered that menubar.js has it's own event handler that is normally used to open the submenu for when enter is pressed or when down is pressed. this didn't work out.

main.js is what handles the alt press, so having this disconnect, I poked around to see if there was any way to tell the menubar to open the submenu from menu.js' event handler, I found that there's an option that's called e.stopPropagation(), to let main.js "pass" the key input along to any other handler.

I currently got the file menu to open after pressing it twice, have yet to figure out how to get it to work after only one press.

Comments

Post a Comment

Popular posts from this blog

#Python-dev: adding pathlike functionality

Image
https://bugs.python.org/issue32642 https://github.com/python/cpython/pull/5691 I've been working with the import library, adding a pathlike object function for sys.path, after making some changes I needed to run "make regen-importlib" to update the importlib_external.h, to allow the changes to go through since I'm modifying a core lib. after testing some I realized something was off, considering one of the tests was taking over 41 hours to complete, I started off by checking for conflicts to see if I was behind on some update they may have done to fix this down the line.... turns out my import library source code (not the .h) was out of date from the current version which caused a merge conflict in on the PR, which also caused appveyor to break, I fixed it easily by using Atom and clicking the "fix  conflict button, which created a dropdown menu of which one to keep, "use ours" vs "use theirs", then after selecting the appropriate one...
Read more

#Python-dev: Starting to contribute to (c)python

 Python Dev   I recently started trying to contribute to python (aka python-dev), so far I've found the IRC is #python-dev, the way that I've been getting there is by using freenode , (you can also get there by searching freenode and clicking the "chat" button), I have noticed that the IRC channel can get you some help but, I've had mixed results I got a response for my first question but after that I didn't get a response (your millage may vary) I also discovered that Cygwin (a bash terminal within windows) isn't fully supported by cpython I also found this mailing list , that I've signed up for and I've already received some emails, so far I've emailed to python-dev@python.org, that apparently sends an email to ALL members, I don't know if this is a good way to reach them as I only sent this email yesterday and haven't gotten a response.  I just posted a bug about what I'm experiencing since running the test command res...
Read more

Working on my first open source bug/request

The bug I've been focusing on first is https://github.com/mozilla/network/issues/798 it's not technically a bug as much as it is removing unused code from the old API that they used before, I tried setting up the build environment on my Windows laptop but quickly came across issues with setting up the actual virtual environment for python. I switched to my Ubuntu laptop and everything went smoothly after, I could go back and setup the windows env now since I do understand what went wrong after successfully getting it to work on Ubuntu. The person that posted that bug is suuuper nice and so far been really helpful with my questions for familiarizing myself with a new system. issue is now I realized I forgot to make a branch before starting my work so I'm wondering how I'll resolve this issue if it is one.  I tried pushing the new branch to the repo and discovered that I don't have permission to directly commit to it so I forked it and pushed to that and now ...
Read more