#Python-dev: First contribution to (c)python

First PR (pull request)


Requirements:

I discovered that to be able to contribute you need to have a few things

1.A Github account (this is a must for anyone wanting to contribute to any open-source project)

2.A python issue tracker account (on this site https://bugs.python.org/)
 -you need to then have your Github account username in the "your details" section of your account (if you set your Github username during reregistration then it should already be set)



3. Sign a this CLA that's also on their site entering the same Github and python issue tracker account for the info. note that the CLA takes 1 American work day (so 24 hrs within Monday-Friday)

4. when you make the pull request it has to be bpo-(issue number): description
  -note there are special rules for back fixing (it will show up in the description of the PR when you make it)

5. if it hasn't been previously done you have to make whats called a news file under the misc/NEWS.d/next folder, the sub folder depends on what the change falls under, the formatting as is as follows

<datetime>.bpo-<issue-number>.<nonce>.rst:
  • <datetime> is today’s date joined with a - to the current time, in YYYY-MM-DD-hh-mm-ss format, e.g. 2017-05-27-16-46-23
  • <issue-number> is the issue number the change is for, e.g. 12345 for bpo-12345
  • <nonce> is some “unique” string to guarantee the file name is unique across branches, e.g. Yl4gI2 (typically six characters, but it can be any length of letters and numbers, and its uniqueness can be satisfied by typing random characters on your keyboard)
So a file name may be Misc/NEWS.d/next/Library/2017-05-27-16-46-23.bpo-12345.Yl4gI2.rst.

My Pull Request: 


My first pull request is: https://github.com/python/cpython/pull/5329

The "patch" made in this pull request was made by someone else, I just downloaded the patch and installed it by calling "git apply [filename]" and tested it by running the new test file included in the patch, confirming it passes and then removing the patched file and confirming the *new* test fails (aka git checkout [patched file] then run the test)


I'm currently still waiting on my CLA to be confirmed so it can take a while, if it takes longer than 3 days it could be good to poke someone on the IRC and see if anyone can poke the people responsible for the CLA confirmation.

Turns out the CLA confirmation on the PR wasn't updating for some reason, if you're sure you've done the signing correctly, then poke the IRC for someone to "cycle" the tag for you, if it's still not done, then they should be able to help you on the IRC.




Comments

Post a Comment

Popular posts from this blog

#Python-dev: adding pathlike functionality

Image
https://bugs.python.org/issue32642 https://github.com/python/cpython/pull/5691 I've been working with the import library, adding a pathlike object function for sys.path, after making some changes I needed to run "make regen-importlib" to update the importlib_external.h, to allow the changes to go through since I'm modifying a core lib. after testing some I realized something was off, considering one of the tests was taking over 41 hours to complete, I started off by checking for conflicts to see if I was behind on some update they may have done to fix this down the line.... turns out my import library source code (not the .h) was out of date from the current version which caused a merge conflict in on the PR, which also caused appveyor to break, I fixed it easily by using Atom and clicking the "fix  conflict button, which created a dropdown menu of which one to keep, "use ours" vs "use theirs", then after selecting the appropriate one
Read more

Building Firefox on Linux first time build

Image
My first attempt at building Firefox: currently building it on a Linux distro known as Ubuntu, many linux users will recognize it as it can be considered mainstream. first issue I encountered is that my update URLs in my Ubuntu system was out of date and was getting 404 errors for some of them so I disabled them from the "other software" tab in the Ubuntu software settings screen. the update now works and it's currently installing Modern Mercurial via pip running it as normal and configuring it with preferred settings. watchman filesystem couldn't be found... firefoxtree enabled installing hg wip alias selecting MozReview only (requests bugzilla email address, can't do at the moment) cloning firefox now build had issues do to me running things as root, don't do that  [Error No 13] Permission denied issues resolved and it took around 81min to build, not bad for an old laptop. runs successfully =D made some modifications and rebuil
Read more

#Brave-laptop dev: interesting issue part 2

Image
This is a continuation from my previous blog, I've done further investigation and discovered that the favicon was being invalidated (redownloaded) every frame. and upon further investigation I found that the response header contained the following I did some research and found that modifying this is no easy task and that this setting forces the Favicon to be redownloaded  every time it's updated. Which in this case was every frame since it was being redrawn along with the gradient affect that follows the mouse. My attempts at figuring out how to modify the layer that the favicon is being drawn in is falling flat so far. I got some feedback from some of the brave developers on how to proceed after I declared these findings, that the issue can be resolved by manually saving the image as a URI and adding it to the CSS, but I haven't been able figure out how to convert a image to an URI.
Read more