Looking for more bugs (fixing those bugs)

I've been looking around in generally the same area of GitHub (namely Mozilla/Network) to see if they have anymore issues that I can help with,

I've found one that seems to link to another GitHub project from Mozilla so it looks like a good place to continue my journey in open source

https://github.com/mozilla/foundation.mozilla.org/issues/235

modifications seem to need to take place in the mofo-bootstrap repo in order to apply more seamlessly into all their sites so I've made opened an issue on that repo to see if I can get things rolling.

https://github.com/mozilla/mofo-bootstrap/issues/122

Someone replied and stated that the code was already in for the Network part and all that needed to be done was change a few links and strings, I do plan on changing the Class name to match so that will have to be changed at a later time, after I've changed the class name.

as for the bootstrap part they were using a package called pug to store their urls in a scss file which made them look very strange

like so
background-image: url('data:image/svg+xml,%3Csvg%20width%3D%2218px%22%20height%3D%2218px%22%20viewBox%3D%220%200%2018%2018%22%20version%3D%221.1%22%20xmlns%3D%22http%3A//www.w3.org/2000/svg%22%20xmlns%3Axlink%3D%22http%3A//www.w3.org/1999/xlink%22%3E%0A%20%20%20%20%3C%21--%20Generator%3A%20Sketch%2041.2%20%2835397%29%20-%20http%3A//www.bohemiancoding.com/sketch%20--%3E%0A%20%20%20%20%3Ctitle%3EShape%3C/title%3E%0A%20%20%20%20%3Cdesc%3ECreated%20with%20Sketch.%3C/desc%3E%0A%20%20%20%20%3Cdefs%3E%3C/defs%3E%0A%20%20%20%20%3Cg%20id%3D%22All%22%20stroke%3D%22none%22%20stroke-width%3D%221%22%20fill%3D%22none%22%20fill-rule%3D%22evenodd%22%3E%0A%20%20%20%20%20%20%20%20%3Cg%20id%3D%22community%22%20fill%3D%22%23ffffff%22%3E%0A%20%20%20%20%20%20%20%20%20%20%20%20%3Cpath%20d%3D%22M9%2C0%20C4%2C0%200%2C4%200%2C9%20C0%2C14%204%2C18%209%2C18%20C14%2C18%2018%2C14%2018%2C9%20C18%2C4%2014%2C0%209%2C0%20L9%2C0%20Z%20M6.3%2C5.6%20C7%2C5.6%207.6%2C6.2%207.6%2C6.9%20C7.6%2C7.6%207%2C8.2%206.3%2C8.2%20C5.6%2C8.2%205%2C7.7%205%2C7%20C5%2C6.2%205.6%2C5.6%206.3%2C5.6%20L6.3%2C5.6%20Z%20M12.8%2C11.5%20C12.3%2C13.2%2010.7%2C14.3%209%2C14.3%20C7.2%2C14.3%205.7%2C13.2%205.2%2C11.5%20C5.1%2C11.1%205.3%2C10.8%205.6%2C10.7%20C5.9%2C10.6%206.3%2C10.8%206.4%2C11.1%20C6.8%2C12.2%207.8%2C13%209%2C13%20C10.2%2C13%2011.2%2C12.2%2011.5%2C11.1%20C11.6%2C10.7%2012%2C10.5%2012.3%2C10.7%20C12.7%2C10.8%2012.9%2C11.1%2012.8%2C11.5%20L12.8%2C11.5%20Z%20M11.7%2C8.3%20C11%2C8.3%2010.4%2C7.7%2010.4%2C7%20C10.4%2C6.3%2011%2C5.7%2011.7%2C5.7%20C12.4%2C5.7%2013%2C6.2%2013%2C7%20C13%2C7.7%2012.4%2C8.3%2011.7%2C8.3%20L11.7%2C8.3%20Z%22%20id%3D%22Shape%22%3E%3C/path%3E%0A%20%20%20%20%20%20%20%20%3C/g%3E%0A%20%20%20%20%3C/g%3E%0A%3C/svg%3E');
view raw gistfile1.txt hosted with ❤ by GitHub



turns out they had another file that pug used to convert to that syntax so I don't have to convert it manually (as in parts of the scss is program generated)

my pull requests for "Network" and "mofo-bootstrap" respectively
https://github.com/mozilla/foundation.mozilla.org/pull/927
https://github.com/mozilla/mofo-bootstrap/pull/123

BOTH PRs were Merged and closed =D

Comments

Post a Comment

Popular posts from this blog

#Python-dev: adding pathlike functionality

Image
https://bugs.python.org/issue32642 https://github.com/python/cpython/pull/5691 I've been working with the import library, adding a pathlike object function for sys.path, after making some changes I needed to run "make regen-importlib" to update the importlib_external.h, to allow the changes to go through since I'm modifying a core lib. after testing some I realized something was off, considering one of the tests was taking over 41 hours to complete, I started off by checking for conflicts to see if I was behind on some update they may have done to fix this down the line.... turns out my import library source code (not the .h) was out of date from the current version which caused a merge conflict in on the PR, which also caused appveyor to break, I fixed it easily by using Atom and clicking the "fix  conflict button, which created a dropdown menu of which one to keep, "use ours" vs "use theirs", then after selecting the appropriate one...
Read more

#Python-dev: Starting to contribute to (c)python

 Python Dev   I recently started trying to contribute to python (aka python-dev), so far I've found the IRC is #python-dev, the way that I've been getting there is by using freenode , (you can also get there by searching freenode and clicking the "chat" button), I have noticed that the IRC channel can get you some help but, I've had mixed results I got a response for my first question but after that I didn't get a response (your millage may vary) I also discovered that Cygwin (a bash terminal within windows) isn't fully supported by cpython I also found this mailing list , that I've signed up for and I've already received some emails, so far I've emailed to python-dev@python.org, that apparently sends an email to ALL members, I don't know if this is a good way to reach them as I only sent this email yesterday and haven't gotten a response.  I just posted a bug about what I'm experiencing since running the test command res...
Read more

Working on my first open source bug/request

The bug I've been focusing on first is https://github.com/mozilla/network/issues/798 it's not technically a bug as much as it is removing unused code from the old API that they used before, I tried setting up the build environment on my Windows laptop but quickly came across issues with setting up the actual virtual environment for python. I switched to my Ubuntu laptop and everything went smoothly after, I could go back and setup the windows env now since I do understand what went wrong after successfully getting it to work on Ubuntu. The person that posted that bug is suuuper nice and so far been really helpful with my questions for familiarizing myself with a new system. issue is now I realized I forgot to make a branch before starting my work so I'm wondering how I'll resolve this issue if it is one.  I tried pushing the new branch to the repo and discovered that I don't have permission to directly commit to it so I forked it and pushed to that and now ...
Read more