Looking for more bugs (fixing those bugs)

I've been looking around in generally the same area of GitHub (namely Mozilla/Network) to see if they have anymore issues that I can help with,

I've found one that seems to link to another GitHub project from Mozilla so it looks like a good place to continue my journey in open source

https://github.com/mozilla/foundation.mozilla.org/issues/235

modifications seem to need to take place in the mofo-bootstrap repo in order to apply more seamlessly into all their sites so I've made opened an issue on that repo to see if I can get things rolling.

https://github.com/mozilla/mofo-bootstrap/issues/122

Someone replied and stated that the code was already in for the Network part and all that needed to be done was change a few links and strings, I do plan on changing the Class name to match so that will have to be changed at a later time, after I've changed the class name.

as for the bootstrap part they were using a package called pug to store their urls in a scss file which made them look very strange

like so
background-image: url('data:image/svg+xml,%3Csvg%20width%3D%2218px%22%20height%3D%2218px%22%20viewBox%3D%220%200%2018%2018%22%20version%3D%221.1%22%20xmlns%3D%22http%3A//www.w3.org/2000/svg%22%20xmlns%3Axlink%3D%22http%3A//www.w3.org/1999/xlink%22%3E%0A%20%20%20%20%3C%21--%20Generator%3A%20Sketch%2041.2%20%2835397%29%20-%20http%3A//www.bohemiancoding.com/sketch%20--%3E%0A%20%20%20%20%3Ctitle%3EShape%3C/title%3E%0A%20%20%20%20%3Cdesc%3ECreated%20with%20Sketch.%3C/desc%3E%0A%20%20%20%20%3Cdefs%3E%3C/defs%3E%0A%20%20%20%20%3Cg%20id%3D%22All%22%20stroke%3D%22none%22%20stroke-width%3D%221%22%20fill%3D%22none%22%20fill-rule%3D%22evenodd%22%3E%0A%20%20%20%20%20%20%20%20%3Cg%20id%3D%22community%22%20fill%3D%22%23ffffff%22%3E%0A%20%20%20%20%20%20%20%20%20%20%20%20%3Cpath%20d%3D%22M9%2C0%20C4%2C0%200%2C4%200%2C9%20C0%2C14%204%2C18%209%2C18%20C14%2C18%2018%2C14%2018%2C9%20C18%2C4%2014%2C0%209%2C0%20L9%2C0%20Z%20M6.3%2C5.6%20C7%2C5.6%207.6%2C6.2%207.6%2C6.9%20C7.6%2C7.6%207%2C8.2%206.3%2C8.2%20C5.6%2C8.2%205%2C7.7%205%2C7%20C5%2C6.2%205.6%2C5.6%206.3%2C5.6%20L6.3%2C5.6%20Z%20M12.8%2C11.5%20C12.3%2C13.2%2010.7%2C14.3%209%2C14.3%20C7.2%2C14.3%205.7%2C13.2%205.2%2C11.5%20C5.1%2C11.1%205.3%2C10.8%205.6%2C10.7%20C5.9%2C10.6%206.3%2C10.8%206.4%2C11.1%20C6.8%2C12.2%207.8%2C13%209%2C13%20C10.2%2C13%2011.2%2C12.2%2011.5%2C11.1%20C11.6%2C10.7%2012%2C10.5%2012.3%2C10.7%20C12.7%2C10.8%2012.9%2C11.1%2012.8%2C11.5%20L12.8%2C11.5%20Z%20M11.7%2C8.3%20C11%2C8.3%2010.4%2C7.7%2010.4%2C7%20C10.4%2C6.3%2011%2C5.7%2011.7%2C5.7%20C12.4%2C5.7%2013%2C6.2%2013%2C7%20C13%2C7.7%2012.4%2C8.3%2011.7%2C8.3%20L11.7%2C8.3%20Z%22%20id%3D%22Shape%22%3E%3C/path%3E%0A%20%20%20%20%20%20%20%20%3C/g%3E%0A%20%20%20%20%3C/g%3E%0A%3C/svg%3E');
view raw gistfile1.txt hosted with ❤ by GitHub




turns out they had another file that pug used to convert to that syntax so I don't have to convert it manually (as in parts of the scss is program generated)

my pull requests for "Network" and "mofo-bootstrap" respectively
https://github.com/mozilla/foundation.mozilla.org/pull/927
https://github.com/mozilla/mofo-bootstrap/pull/123

BOTH PRs were Merged and closed =D

Comments

Popular posts from this blog

#Python-dev: adding pathlike functionality

#Python-dev: Starting to contribute to (c)python

Working on my first open source bug/request